Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement origin for pandas resampling #1962

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Implement origin for pandas resampling #1962

wants to merge 3 commits into from

Conversation

vasil-pashov
Copy link
Collaborator

@vasil-pashov vasil-pashov commented Oct 29, 2024 •
edited
Loading

Reference Issues/PRs

What does this implement or fix?

Implements equivalent of pandas origin in ArcticDB's resample. The default is set to epoch which matches the default behavior of Arctic up to now but is different than Pandas which uses start_day. Changing it to start_day is a breaking change.

TODO:

  • Think about user specified date range combined with resample=start and resample=end
  • Better testing

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 will be requested when the pull request is marked ready for review alexowens90 is a code owner

@willdealtry willdealtry Awaiting requested review from willdealtry willdealtry will be requested when the pull request is marked ready for review willdealtry is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars will be requested when the pull request is marked ready for review poodlewars is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vasil-pashov